Attention is currently required from: dexter, hampushellsberg, jolly, laforge.

hampushellsberg uploaded patch set #2 to this change.

View Change

The following approvals got outdated and were removed: Code-Review+1 by laforge, Verified+1 by Jenkins Builder

esim.saip: fix decoding of rfu PEs with an empty body

rfu1..rfu5 are PE-Dummy, an empty SEQUENCE. from_der() creates a
generic ProfileElement for them and sets the type afterwards, but the
constructor treated the empty dict like a new PE and derived a header
name from the unset type, so a profile with such a PE failed to load
with an AttributeError. Only create a header if 'decoded' is None, as
documented.

The folder osmocom-pysim-saip-empty-pe-body of
hampushellsberg-dev/PySIM-upstream-patches on GitHub has the analysis
and a repro.

Change-Id: Ic47f74e8c111643c4ba435a9bac6aa9838bd3584
---
M pySim/esim/saip/__init__.py
M tests/unittests/test_esim_saip.py
2 files changed, 18 insertions(+), 1 deletion(-)

git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/12/44012/2

To view, visit change 44012. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: newpatchset
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ic47f74e8c111643c4ba435a9bac6aa9838bd3584
Gerrit-Change-Number: 44012
Gerrit-PatchSet: 2
Gerrit-Owner: hampushellsberg <hampushellsberg@gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier@sysmocom.de>
Gerrit-Reviewer: jolly <andreas@eversberg.eu>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Attention: hampushellsberg <hampushellsberg@gmail.com>
Gerrit-Attention: jolly <andreas@eversberg.eu>
Gerrit-Attention: laforge <laforge@osmocom.org>
Gerrit-Attention: dexter <pmaier@sysmocom.de>