Attention is currently required from: daniel, laforge, pespin.
6 comments:
Patchset:
why is VTY tests failing here? please explain.
Answer in the thread above.
/unresolv it.
The vty tests fails, because I'm adding a new command which contains more characters than all previous valid commands, which adds more indention to the help message.
But I can't change the expected output to contain more spaces, because than this would fails when not compiling with tcap loadsharing.
Only one of the build checks fails here
Commit Message:
Patch Set #3, Line 19: Defaults to reject-utds.
udts (everywhere you wrote it)
I was very consistent and wrote it everywhere the wrong way. will fix it.
File src/tcap_as_loadshare.c:
Patch Set #3, Line 257: static struct osmo_ss7_asp *select_asp_tcap_enabled_rr(struct osmo_ss7_as *as, bool fallback)
Having this param here only to tick a rate_ctr look weird tbh, I'd rather move this to the caller, a […]
ok, will change it.
Patch Set #3, Line 555: if (!asp && as->cfg.loadshare.tcap.unroutable_tcap_msg == SS7_AS_TCAP_UNROUTABLE_LOAD_SHARE_AS)
else if (as->cfg.loadshare.tcap. […]
Acknowledged
Patch Set #3, Line 556: asp = select_asp_tcap_enabled_rr(as, true);
shouldn't we be adding a track_entry here (move the call above here) so that when an Abort/End for t […]
yes, you're right.
To view, visit change 42760. To unsubscribe, or for help writing mail filters, visit settings.