laforge submitted this change.

View Change

fixup: bts: create all components alive

Making the ConnHdlr and lapdm_CT components alive resulted in
massive regressions.  Specifically, trxcon started rejecting L1CTL
connections with the following message:

  L1CTL server cannot accept more than 1 connection(s)

Apparently, alive components do not close the L1CTL connection
automatially, unless the L1CTL port is unmap()ped from the system
explicitly.  Thus, testcases spawning multiple alive components
end up creating multiple L1CTL connections, which get rejected.

Let's revert those components that speak L1CTL back to normal
(non-alive), while keeping the emulation components alive.

Change-Id: Id5edfa2514024d1fe83f6c4082e096044ce8e6fd
Fixes: 713e7a86 ("bts: create all components alive")
---
M bts/BTS_Tests.ttcn
M bts/BTS_Tests_LAPDm.ttcn
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn
index 455e696..7bac7ee 100644
--- a/bts/BTS_Tests.ttcn
+++ b/bts/BTS_Tests.ttcn
@@ -695,7 +695,7 @@
 	var charstring id := testcasename();
 	var ConnHdlr vc_conn;
 
-	vc_conn := ConnHdlr.create(id) alive;
+	vc_conn := ConnHdlr.create(id);
 	/* connect to RSL Emulation main component */
 	connect(vc_conn:RSL, vc_RSL:CLIENT_PT);
 	connect(vc_conn:RSL_PROC, vc_RSL:RSL_PROC);
diff --git a/bts/BTS_Tests_LAPDm.ttcn b/bts/BTS_Tests_LAPDm.ttcn
index 0510695..fef2383 100644
--- a/bts/BTS_Tests_LAPDm.ttcn
+++ b/bts/BTS_Tests_LAPDm.ttcn
@@ -24,7 +24,7 @@
 
 function f_lapdm_init() runs on lapdm_test_CT {
 	/* create the LAPDm component */
-	lapdm_component := lapdm_CT.create alive;
+	lapdm_component := lapdm_CT.create;
 	/* connect our own LAPDM port to the LAPDM Service Provider of the LAPDm component */
 	connect(self:LAPDM, lapdm_component:LAPDM_SP);
 	/* connect the LAPDm compoent's lower-side port to the system L1CTL port (which is internally

To view, visit change 41646. To unsubscribe, or for help writing mail filters, visit settings.