Attention is currently required from: osmith, pespin.

Patch set 6:Code-Review +1

View Change

3 comments:

• File src/rlcmac/rlcmac_dec.c:

  • Patch Set #6, Line 437: t3 = tbf_start_time->N51

    Are you sure this is correct? On the left (before this patch) `t3` field was assigned the value of `tbf_start_time->N26`, but now it's `tbf_start_time->N51`. Ah, now it matches what `gsm_fn2gsmtime()` is doing, so looks correct. Nevermind.

  • Patch Set #6, Line 439: 51 * OSMO_MOD_FLR((t3 - t2), 26) + t3 + 51 * 26 * t1p;

    AFAICS, this is pretty much a copy-paste from libosmogsm. Is there a reason to reinvent `gsm_gsmtime2fn()` here? Can't we keep the function as it was, and simply do `gsm_rfn2fn`?

    ```
    const uint16_t rfn = gsm_gsmtime2fn(&g_time);
    const uint32_t fn = gsm_rfn2fn(rfn, curr_fn);
    ```

• File tests/rlcmac/rlcmac_types_test.c:

  • Patch Set #3, Line 54: printf

    This allows easily separating internal logging from test specific logging. […]

    Not blocking, marking as resolved.

To view, visit change 34044. To unsubscribe, or for help writing mail filters, visit settings.