Attention is currently required from: Timur Davydov, pespin.

View Change

11 comments:

• File Transceiver52M/Transceiver.h:

  • Robot Comment from checkpatch (run ID ):

    Patch Set #10, Line 246: int driveReceiveRadioShortVector(std::vector<short *> &bufs, int samples, int underrun,

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #10, Line 247: TIMESTAMP ts, unsigned samples_skipped);

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID ):

    Patch Set #10, Line 249: bool driveReceiveRadio(unsigned samples_skipped = 0);

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #10, Line 258: bool driveReceiveFIFO(size_t chan, char *burstBuffer = nullptr, size_t burstBufferLen = 0);

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #10, Line 264: @brief modulation and sorting of GSM bursts from GSM core

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #10, Line 265: @param chan channel number

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #10, Line 266: @param burstBuffer optional buffer containing burst to transmit, if not provided, will read from data socket

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #10, Line 267: @param burstBufferLen optional length of burst buffer, if not provided, will read from data socket

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #10, Line 270: bool driveTxPriorityQueue(size_t chan, char *burstBuffer = nullptr, size_t burstBufferLen = 0);

    please, no spaces at the start of a line

• File Transceiver52M/radioInterface.h:

  • Robot Comment from checkpatch (run ID ):

    Patch Set #10, Line 118: int driveReceiveRadio(unsigned samples_skipped = 0);

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #10, Line 137: int fillPullBuffer(std::vector<short *> &bufs, size_t samples, int recvunderrun, TIMESTAMP ts);

    please, no spaces at the start of a line

To view, visit change 42411. To unsubscribe, or for help writing mail filters, visit settings.