laforge submitted this change.

View Change


Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved
make our tests pass pylint

Change-Id: If3a9f178c3f915123178efe00269fce74f6e585d
---
M tests/test_globalplatform.py
M tests/test_tlv.py
2 files changed, 22 insertions(+), 0 deletions(-)

diff --git a/tests/test_globalplatform.py b/tests/test_globalplatform.py
index 62eb43e..8496018 100644
--- a/tests/test_globalplatform.py
+++ b/tests/test_globalplatform.py
@@ -71,6 +71,14 @@
get_eid_cmd_plain = h2b('80E2910006BF3E035C015A')
get_eid_rsp_plain = h2b('bf3e125a1089882119900000000000000000000005')

+ # must be overridden by derived classes
+ init_upd_cmd = b''
+ init_upd_rsp = b''
+ ext_auth_cmd = b''
+ get_eid_cmd = b''
+ get_eid_rsp = b''
+ keyset = None
+
@property
def host_challenge(self) -> bytes:
return self.init_upd_cmd[5:]
@@ -102,18 +110,22 @@
cls.scp = SCP03(card_keys = cls.keyset)

def test_01_initialize_update(self):
+ # pylint: disable=no-member
self.assertEqual(self.init_upd_cmd, self.scp.gen_init_update_apdu(self.host_challenge))

def test_02_parse_init_upd_resp(self):
self.scp.parse_init_update_resp(self.init_upd_rsp)

def test_03_gen_ext_auth_apdu(self):
+ # pylint: disable=no-member
self.assertEqual(self.ext_auth_cmd, self.scp.gen_ext_auth_apdu(self.security_level))

def test_04_wrap_cmd_apdu_get_eid(self):
+ # pylint: disable=no-member
self.assertEqual(self.get_eid_cmd, self.scp.wrap_cmd_apdu(self.get_eid_cmd_plain))

def test_05_unwrap_rsp_apdu_get_eid(self):
+ # pylint: disable=no-member
self.assertEqual(self.get_eid_rsp_plain, self.scp.unwrap_rsp_apdu(h2b('9000'), self.get_eid_rsp))


diff --git a/tests/test_tlv.py b/tests/test_tlv.py
index 1e5000d..0e73ab1 100644
--- a/tests/test_tlv.py
+++ b/tests/test_tlv.py
@@ -17,6 +17,7 @@
# along with this program. If not, see <http://www.gnu.org/licenses/>.

import unittest
+from construct import Int8ub
from pySim.tlv import *

class TestUtils(unittest.TestCase):

To view, visit change 35804. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: If3a9f178c3f915123178efe00269fce74f6e585d
Gerrit-Change-Number: 35804
Gerrit-PatchSet: 3
Gerrit-Owner: laforge <laforge@osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-MessageType: merged