Attention is currently required from: jolly, laforge, pespin.

View Change

1 comment:

• File src/osmo-bsc/system_information.c:

  • Patch Set #2, Line 1447: 32

    Done

    Thanks for adding the comment. I still see a possible problem though. By doing `< 32` you're actually limiting number the neighbors you check here in this function, not the number of frequencies the SI10 can fit.

    Imagine having more than 32 neighbors in the list (weird, but still possible, right?). The current logic would not take those neighbors with `i >= 32` into account, despite they could be involved in group calls and could fit.

    Does that make sense?
    If yes, just limit to `nbv->data_len * 8` and rely on your overflow detection logic below.

To view, visit change 34626. To unsubscribe, or for help writing mail filters, visit settings.