Attention is currently required from: pespin.

View Change

2 comments:

• File src/core/tun.c:

  • Patch Set #12, Line 402:

    if_index = if_nametoindex(dev_name);
    	if (if_index == 0)
    		return -ENODEV;
    

    I think it's dangerous to use the string as a persistent/permanent identifier for a network device. That's what the ifindex is normally used for. It is unique even across device renames. Is there a specific reeason why you're not storing the ifindex in the local state structure and use that every time another operation is performed?

    It looks a bit odd that every API function here first performs a name-to-ifindex translation.

  • Patch Set #12, Line 639: /

    what's this about?

To view, visit change 31025. To unsubscribe, or for help writing mail filters, visit settings.