Attention is currently required from: fixeria.
Patch set 1:Code-Review +1
View Change
1 comment:
File src/fsm.c:
Patch Set #1, Line 691: timeout_ms % 1000
I wouldn't be sure of operator precendence here without looking at the C standard and would put (timeout_ms % 1000) in parenthesis.
To view, visit change 28649. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ib0b6c3bdb56e4279df9e5ba7db16841645c452aa
Gerrit-Change-Number: 28649
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Comment-Date: Tue, 19 Jul 2022 07:08:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment