lynxis lazus has uploaded this change for review.

View Change

gprs_ns2_sns: fix error cases of SNS_ADD

When adding a NS-VC fails, the SNS-ACK with failure code should follow,
but no second SNS-ACK.

Related: OS#6611
Change-Id: I06bc2622f89256d9675e29b49acc7a3e0647eeae
---
M src/gb/gprs_ns2_sns.c
1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/16/39016/1

diff --git a/src/gb/gprs_ns2_sns.c b/src/gb/gprs_ns2_sns.c
index a17861b..29ccfb0 100644
--- a/src/gb/gprs_ns2_sns.c
+++ b/src/gb/gprs_ns2_sns.c
@@ -1241,7 +1241,7 @@
 					do_sns_delete(fi, &v4_list[j], NULL);
 				cause = -rc;
 				ns2_tx_sns_ack(gss->sns_nsvc, trans_id, &cause, NULL, 0, NULL, 0);
-				break;
+				return;
 			}
 		}
 	} else { /* IPv6 */
@@ -1262,7 +1262,7 @@
 					do_sns_delete(fi, NULL, &v6_list[j]);
 				cause = -rc;
 				ns2_tx_sns_ack(gss->sns_nsvc, trans_id, &cause, NULL, 0, NULL, 0);
-				break;
+				return;
 			}
 		}
 	}

To view, visit change 39016. To unsubscribe, or for help writing mail filters, visit settings.