Attention is currently required from: laforge, daniel.
Patch set 5:Code-Review +1
View Change
1 comment:
File src/core/osmo_io.c:
Patch Set #3, Line 249: } else if (pending_len < 0) {
I think it's more important what someone else who didn't write this thinks. […]
Ah I see the rationale now :) It should have been "msg_pending_len" then or similar, otherwise it's confusing since there are 2 messages.
To view, visit change 32758. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I6a0eebb8d4490f09a3cc6eb97d4ff47b4a8fd377
Gerrit-Change-Number: 32758
Gerrit-PatchSet: 5
Gerrit-Owner: daniel <dwillmann@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-Attention: laforge <laforge@osmocom.org>
Gerrit-Attention: daniel <dwillmann@sysmocom.de>
Gerrit-Comment-Date: Fri, 19 May 2023 11:05:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pespin@sysmocom.de>
Comment-In-Reply-To: daniel <dwillmann@sysmocom.de>
Gerrit-MessageType: comment