Attention is currently required from: fixeria.

Patch set 3:Code-Review -1

View Change

1 comment:

• Patchset:

  • Patch Set #3:

    well an _init() function is expected to initialize something that was provided by the caller. Now the funciton is called _alloc() which hints that is allocating something.

    Your commit log just mentions about the pointer return value and nothing about the rename. If the function really is allocating some memory, then the rename makes sense - but that should be mentioned.

To view, visit change 28549. To unsubscribe, or for help writing mail filters, visit settings.