Attention is currently required from: osmith.

View Change

1 comment:

• File asterisk/AMI_Functions.ttcn:

  • Patch Set #3, Line 260:

    	/* TEXT Enc/dec is not happy with values containing "; ", get rid of them:
    	 * "AppData: 5,0502: Call pjsip endpoint from 0501\r\n" */
    	var integer pos := f_strstr(patched_txt, "AppData: ", 0);
    	if (pos >= 0) {
    		var integer pos_end := f_strstr(patched_txt, "\r\n", pos) + lengthof("\r\n");
    		var charstring to_remove := substr(patched_txt, pos, pos_end - pos);
    		patched_txt := f_str_replace(patched_txt, to_remove, "");
    	}
    

    I don't understand what this does. […]

    It's removing the full line "AppData: 5,0502: Call pjsip endpoint from 0501\r\n", since we don't need it for now and just breaks the decoder (yes, this all should be fixed better at a later point in in TITAN TEXT decoder).

    1- Find pos of "AppData" substr start.
    2- From there, find where the line finishes by finding "\r\n".
    3- Create a substr of that line.
    4- Use f_str_replace() to remove that line entirely.

    
    EDIT: Ah! I see what you mean, I put a typo in the comment, I meant ": ".

To view, visit change 36755. To unsubscribe, or for help writing mail filters, visit settings.