Attention is currently required from: fixeria, laforge, pespin.
View Change
1 comment:
Patchset:
Patch Set #5:
it looks good from a quick glance, however the build fails:
```
===> Compiling src/logger_gsmtap_h.erl failed
src/logger_gsmtap_h.erl:61:17: syntax error before: 0.0
src/logger_gsmtap_h.erl:84:2: Warning: behaviour logger_handler undefined
```
To view, visit change 39415. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: Iea884e2ca146b852c64bd9f135d8c71f4c925f09
Gerrit-Change-Number: 39415
Gerrit-PatchSet: 5
Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: osmith <osmith@sysmocom.de>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-Attention: laforge <laforge@osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Attention: pespin <pespin@sysmocom.de>
Gerrit-Comment-Date: Mon, 27 Jan 2025 07:46:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No