Attention is currently required from: falconia.

Patch set 1:Code-Review +1

View Change

3 comments:

• File src/twjit.c:

  • Patch Set #1, Line 554: twjit->stats.underruns++;

    shouldn't "twjit->stats.too_old++;" be increased too here if id == INPUT_TOO_OLD?

  • Patch Set #1, Line 630: static void handle_flowing_underrun(struct osmo_twjit *twjit)

    Some ideas, no need to apply them if you don't want:

    It may make sense to specify here that this is expected to be called from state TWJIT_STATE_FLOWING. It may even make sense to merge it into osmo_twjit_output().

    Or maybe change this function into being only the content of the "if" path, and name it "transition_to_state_underrun()" or "state_underrun_onenter()" or similar. See comment below.

  • Patch Set #1, Line 671: if (read_sb_is_empty(twjit)) {

    if (!read_sb_is_empty(twjit)) {
            read_sb_thinning(twjit);
            return pull_from_read_sb(twjit);
        }
        if (twjit->config.underrun_ext)
            transition_to_state_underrun(twjit);
        else
            twjit->state = TWJIT_STATE_EMPTY;
        return NULL;

To view, visit change 42141. To unsubscribe, or for help writing mail filters, visit settings.