Attention is currently required from: falconia, pespin.

View Change

1 comment:

• File src/hlr_sms.c:

  • Patch Set #2, Line 136: char smsc_addr[21];

    Adding libsmpp34 as a mandatory dependency for osmo-hlr is a horrible idea. […]

    Adding `libsmpp34` dependency is indeed not a good idea, given that osmo-hlr has nothing to to with SMPP. I am fine with defining this value in `osmocom/gsm/protocol/gsm_04_11.h` and using here, but I would not block because of that.

To view, visit change 34449. To unsubscribe, or for help writing mail filters, visit settings.