Attention is currently required from: daniel, fixeria, osmith.

osmith uploaded patch set #3 to this change.

View Change

The following approvals got outdated and were removed: Code-Review+1 by daniel, Code-Review+1 by fixeria, Verified+1 by osmith

Fix decoding of TCAP messages

Recent versions of asn1c fail while decoding the DialoguePortion of a TCAP
message - probably because Tag APPLICATION 11 is sent as constructed tag and
the WS adaptation expects a primitive one. Not sure if this ever worked
with an older asn1c version, maybe it ignored this discrepancy.

The described behavior also happens with mouse07410/asn1c 2c06555 used
in the next patch to regenerate the code.

In any case the correct encoding of the DialoguePortion is as EXTERNAL.
Support for proper EXTERNAL asn1c decoding is missing in all versions of asn1c
except https://github.com/mouse07410/asn1c (See PR #3/#5) so use that
when regenerating.

Related: SYS#7486
Change-Id: I4a27a52b2be70b1fc50e0a3d5441ded4c151fe65
---
M asn/tcap.asn
1 file changed, 3 insertions(+), 3 deletions(-)

git pull ssh://gerrit.osmocom.org:29418/libosmo-asn1-tcap refs/changes/21/41021/3

To view, visit change 41021. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: newpatchset
Gerrit-Project: libosmo-asn1-tcap
Gerrit-Branch: master
Gerrit-Change-Id: I4a27a52b2be70b1fc50e0a3d5441ded4c151fe65
Gerrit-Change-Number: 41021
Gerrit-PatchSet: 3
Gerrit-Owner: osmith <osmith@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: osmith <osmith@sysmocom.de>
Gerrit-CC: daniel <dwillmann@sysmocom.de>
Gerrit-CC: pespin <pespin@sysmocom.de>
Gerrit-Attention: osmith <osmith@sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Attention: daniel <dwillmann@sysmocom.de>