Attention is currently required from: dexter.

Patch set 8:Code-Review -2

View Change

1 comment:

• Commit Message:

  • Patch Set #8, Line 11: Older versions will ignore the settable_object parameter

    Are you sure? Have you tested this at all? In `requirements.txt` we require `cmd2==1.5`, which does not like this argument. I quickly tested this patch in docker:

    ```
    Card initialization failed with an exception:
    ---------------------8<---------------------
    Traceback (most recent call last):
      File "/data/./pySim-shell.py", line 983, in <module>
        app = PysimApp(card, rs, sl, ch, opts.script)
      File "/data/./pySim-shell.py", line 148, in __init__
        self.add_settable(cmd2.Settable('numeric_path', bool, 'Print File IDs instead of names', self,
    TypeError: __init__() takes 4 positional arguments but 5 positional arguments (and 1 keyword-only argument) were given
    ---------------------8<---------------------
    ```

    Either we maintain backwards compatibility with 1.5 and don't break it, or we finally bump the version (at least to 0.8.5, which is provided by debian:bullseye).

To view, visit change 32532. To unsubscribe, or for help writing mail filters, visit settings.