Attention is currently required from: bucketking657, laforge, pespin.

bucketking657 uploaded patch set #4 to this change.

View Change

The following approvals got outdated and were removed: Code-Review+1 by laforge, Code-Review+1 by pespin, Verified+1 by Jenkins Builder

sgsn_libgtp: encode IMEISV via a local LV buffer

gsm48_encode_bcd_number() was called on pdp->imeisv.v with max_len 8,
which only worked because it compares max_len against the L octet. A
16-digit IMEISV needs 9 bytes (L plus 8 octets). Encode into a local
9-byte LV buffer, check the return code, and copy the value part.

Related: OS#7126
Change-Id: Ied06aa05ee6850ec0df34a51cdce6df12e0b594c
---
M src/sgsn/sgsn_libgtp.c
1 file changed, 12 insertions(+), 5 deletions(-)

git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/50/44150/4

To view, visit change 44150. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Ied06aa05ee6850ec0df34a51cdce6df12e0b594c
Gerrit-Change-Number: 44150
Gerrit-PatchSet: 4
Gerrit-Owner: bucketking657 <joshuashilts@gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-Attention: pespin <pespin@sysmocom.de>
Gerrit-Attention: laforge <laforge@osmocom.org>
Gerrit-Attention: bucketking657 <joshuashilts@gmail.com>