Attention is currently required from: osmith.

pespin uploaded patch set #4 to this change.

View Change

The following approvals got outdated and were removed: Code-Review+1 by osmith, Verified+1 by Jenkins Builder

mtp: Improve mtp_sap/ss7_user APIs

* The ss7_user API was so far never used externally, and internally only
by SCCP and a unit test. It has several bad practices like first
passing a inst parent ptr to allocate it, and then require a inst
pointer again to operate on it (eg. register/unregister, send a
primitive, etc.). This only makes the API more complex than needed and
creates potential problems where a isnt differnet than the one ss7_user
was allocated on is passed. Instead, the ss7_user is pinned to its
parent inst during alloction, and all MTP-SAP always happens uniquely
through the ss7_user. This follows much more closely the already
sanitized and much more used sccp_sap/sccp_user APIs.

* Move more primitive/SAP related code to mtp_sap.c, to make it easier to
spot where the inter-layer communication happens. This way we also have
the same disposition as with sccp_sap/sccp_user.

* Clean up some primitive related APIs to unify naming with other usual
SAP/primitive osmocom code.

Change-Id: If320db2bcec7ccbbc2cdac0cbf018fd8be7bde22
---
M TODO-RELEASE
M include/osmocom/sigtran/osmo_ss7.h
M src/mtp_sap.c
M src/sccp_instance.c
M src/sccp_scrc.c
M src/ss7_hmrt.c
M src/ss7_instance.h
M src/ss7_user.c
M src/ss7_user.h
M src/xua_internal.h
M tests/ss7/ss7_test.c
11 files changed, 133 insertions(+), 115 deletions(-)

git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/11/41411/4

To view, visit change 41411. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: newpatchset
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: If320db2bcec7ccbbc2cdac0cbf018fd8be7bde22
Gerrit-Change-Number: 41411
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith@sysmocom.de>
Gerrit-Attention: osmith <osmith@sysmocom.de>