Attention is currently required from: dexter, fixeria.

View Change

7 comments:

• Patchset:

  • Patch Set #1:

    this still needs documentation

    Done

• File contrib/csv-encrypt-columns.py:

  • Patch Set #1, Line 29: def dict_keys_to_upper(d: dict):

    typing hint: `-> dict:`

    Done

  • Patch Set #1, Line 37: def encrypt_col(self, colname:str, value: str):

    typing hint: `-> Hexstr:`?

    Done

  • Patch Set #1, Line 43: def encrypt(self):

    type hint: `-> None:`

    Done

  • Patch Set #1, Line 60: parser.add_argument('CSVFILE', help="CSV file name")

    Idea: you can do `type=argparse. […]

    I really don't see many stdin/stdout use cases for CSV files [with mandatory header, like here], sorry.

  • Patch Set #1, Line 61: default=[],

    I would remove `default` and put `required=True`, since you require at least one argument.

    Done

• File pySim/card_key_provider.py:

  • Patch Set #1, Line 129: str) -> str

    `Hexstr`?

    No, cannot do here as there are other values passing through [if no transport key, it could be anything non-hex]

To view, visit change 36930. To unsubscribe, or for help writing mail filters, visit settings.