Attention is currently required from: neels, msuraev.
9 comments:
File src/host/layer23/include/osmocom/bb/common/vty.h:
Patch Set #8, Line 6: #include <osmocom/vty/command.h>
only vty. […]
include/osmocom/vty/command.h
175:struct cmd_element {
(trailing blank line)
Ack
File src/host/layer23/include/osmocom/bb/modem/vty.h:
Patch Set #8, Line 7: #include <osmocom/bb/common/vty.h>
none of the includes are necessary for this .h, need only […]
Ack
File src/host/layer23/src/common/vty.c:
Patch Set #8, Line 2: * (C) 2010 by Andreas Eversberg <jolly@eversberg.eu>
old (C) for new file?
I copied stuff from another existing file. I'll also add sysmocom copyright for all the new stuff in it.
Patch Set #8, Line 172: int l23_vty_go_parent(struct vty *vty)
you can completely drop vty_go_parent since libosmocore patch […]
Ack
Patch Set #8, Line 186: int l23_vty_init(int (*config_write_ms_node_cb)(struct vty *))
funny how in this patch, you don't check the rc of l23_vty_init() calls anywhere. […]
Done
File src/host/layer23/src/mobile/vty_interface.c:
Patch Set #8, Line 3209: osmo_talloc_vty_add_cmds();
why is this dropped? possibly better in a separate patch?
Because it's added as part of l23_vty_init(). It makes total sense to have it in the same patch.
File src/host/layer23/src/modem/vty.c:
Patch Set #8, Line 2: * (C) 2010 by Andreas Eversberg <jolly@eversberg.eu>
(old (C) for new file)
Ack
(extra blank line)
Ack
To view, visit change 30961. To unsubscribe, or for help writing mail filters, visit settings.