Attention is currently required from: Timur Davydov, fixeria, laforge.
Patch set 11:Code-Review -2
View Change
1 comment:
Patchset:
Patch Set #11:
I don't mind refactoring but cluttering everything with ifdefs is not acceptable, we won't be able to maintain code like that, because we neither run the web backend nor do existing users nor do we want to run it and we don't have tests either. That would mean code rot as soon as anyone changes anything because we don't know where and what to wrap in ifdefs. The only way I see here is to derive/template a WebTransceiver or something like that and just override parts, so this can be somehow contained.
To view, visit change 42411. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: Ia0d340c323c2eea28fbe82601ba0af7cfbd68f6d
Gerrit-Change-Number: 42411
Gerrit-PatchSet: 11
Gerrit-Owner: Timur Davydov <dtv.comp@gmail.com>
Gerrit-Reviewer: Hoernchen <ewild@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-CC: pespin <pespin@sysmocom.de>
Gerrit-Attention: laforge <laforge@osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Attention: Timur Davydov <dtv.comp@gmail.com>
Gerrit-Comment-Date: Wed, 29 Apr 2026 18:10:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes