msuraev submitted this change.

View Change

Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified
SMPP: fix possible NULL pointer dereference

Related: OS#5568
Change-Id: I875eb5249004d3a960aee46c5099592d18fcaa76
---
M src/libsmpputil/smpp_smsc.c
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/libsmpputil/smpp_smsc.c b/src/libsmpputil/smpp_smsc.c
index 059915d..0ee5b62 100644
--- a/src/libsmpputil/smpp_smsc.c
+++ b/src/libsmpputil/smpp_smsc.c
@@ -163,8 +163,8 @@
osmo_fd_unregister(&esme->wqueue.bfd);
close(esme->wqueue.bfd.fd);
esme->wqueue.bfd.fd = -1;
- acl->esme = NULL;
smpp_esme_put(acl->esme);
+ acl->esme = NULL;
}

/* delete all routes for this ACL */

To view, visit change 28848. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I875eb5249004d3a960aee46c5099592d18fcaa76
Gerrit-Change-Number: 28848
Gerrit-PatchSet: 40
Gerrit-Owner: msuraev <msuraev@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: msuraev <msuraev@sysmocom.de>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-CC: neels <nhofmeyr@sysmocom.de>
Gerrit-CC: osmith <osmith@sysmocom.de>
Gerrit-MessageType: merged