lynxis lazus submitted this change.

View Change

Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, but someone else must approve lynxis lazus: Looks good to me, approved
bankd: Remove Mapping: improve logging

Add bank and slot id to the log messages.

Change-Id: I62ddc2f260a6e1a51b1dda5f0822b6caa090452d
---
M src/bankd/bankd_main.c
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/bankd/bankd_main.c b/src/bankd/bankd_main.c
index 14c676d..c43fe97 100644
--- a/src/bankd/bankd_main.c
+++ b/src/bankd/bankd_main.c
@@ -247,15 +247,15 @@
/* Remove a mapping */
map = slotmap_by_bank(g_bankd->slotmaps, &bs);
if (!map) {
- LOGPFSML(srvc->fi, LOGL_ERROR, "could not find to-be-deleted slotmap\n");
+ LOGPFSML(srvc->fi, LOGL_ERROR, "B(%lu:%lu) could not find to-be-deleted slotmap\n", rreq->bank.bankId, rreq->bank.slotNr);
resp = rspro_gen_RemoveMappingRes(ResultCode_unknownSlotmap);
} else {
rspro2client_slot(&cs, &rreq->client);
if (!client_slot_equals(&map->client, &cs)) {
- LOGPFSML(srvc->fi, LOGL_NOTICE, "ClientId in removeMappingReq != map\n");
+ LOGPFSML(srvc->fi, LOGL_NOTICE, "B(%lu:%lu): ClientId in removeMappingReq != map\n", rreq->bank.bankId, rreq->bank.slotNr);
resp = rspro_gen_RemoveMappingRes(ResultCode_unknownSlotmap);
} else {
- LOGPFSML(srvc->fi, LOGL_INFO, "removing slotmap\n");
+ LOGPFSML(srvc->fi, LOGL_INFO, "B(%lu:%lu): removing slotmap\n", rreq->bank.bankId, rreq->bank.slotNr);
bankd_srvc_remove_mapping(map);
resp = rspro_gen_RemoveMappingRes(ResultCode_ok);
}

To view, visit change 39985. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: merged
Gerrit-Project: osmo-remsim
Gerrit-Branch: master
Gerrit-Change-Id: I62ddc2f260a6e1a51b1dda5f0822b6caa090452d
Gerrit-Change-Number: 39985
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis@fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>