osmith submitted this change.

View Change

GSUP: PDP Context ID: start at 1

In OsmoHLR, PDP Contexts can have IDs <1-10>. 0 is used internally to
mark a profile slot as disabled:
https://gitea.osmocom.org/cellular-infrastructure/osmo-hlr/src/commit/d4b4548589f929d7c888ad213bd601ab2a421d8a/src/hlr_vty.c#L201

HLR Test TC_gsup_ul_subscriber_data in osmo-ttcn3-hacks also makes this
assumption:
https://gitea.osmocom.org/ttcn3/osmo-ttcn3-hacks/src/commit/85276b94c474bb649a0c4893b760c7b76f1f342e/hlr/HLR_Tests.ttcn#L1165-L1172

However the new GSUP implementation in PyHSS started its IDs at 0. I've
suggested to start it at 1 here:
https://github.com/nickvsnetworking/pyhss/pull/277/files/4b6da744743877806810b6eade937d2360eb0fbf#r2545727324

Change-Id: I9c39002cb7f7dd81ae0f1f0f9d80df1aaf399f48
---
M common/chapters/gsup.adoc
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/chapters/gsup.adoc b/common/chapters/gsup.adoc
index 824ac90..33d35da 100644
--- a/common/chapters/gsup.adoc
+++ b/common/chapters/gsup.adoc
@@ -1276,7 +1276,7 @@
 ==== PDP Context ID
 
 The PDP type context ID IE consists of a single integer byte wrapped in
-a TLV.
+a TLV. Values for PDP Context ID start at 1 (0 is reserved).
 
 [packetdiag]
 ----

To view, visit change 41471. To unsubscribe, or for help writing mail filters, visit settings.