osmith submitted this change.

View Change



2 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Approvals: pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified
bssmap_handle_ass_req_tp_codec_list: tweak log msg

Remove "speech mode" from the log message, as the log message is
relevant for CSD too. According to 3GPP TS 48.008 ยง 3.2.1.1 note 13 the
IE shall be included for AoIP unless channel type is signalling.

Related: OS#4393
Change-Id: Idfab0b7f6e97a6b67d140f967ddfe9b29818586e
---
M src/osmo-bsc/osmo_bsc_bssap.c
1 file changed, 15 insertions(+), 1 deletion(-)

diff --git a/src/osmo-bsc/osmo_bsc_bssap.c b/src/osmo-bsc/osmo_bsc_bssap.c
index 59d5aa5..e38a975 100644
--- a/src/osmo-bsc/osmo_bsc_bssap.c
+++ b/src/osmo-bsc/osmo_bsc_bssap.c
@@ -977,7 +977,7 @@
}

if (aoip && !conn->codec_list.len) {
- LOGP(DMSC, LOGL_ERROR, "%s: AoIP speech mode Assignment Request:"
+ LOGP(DMSC, LOGL_ERROR, "%s: AoIP Assignment Request:"
" Missing or empty Speech Codec List IE\n", bsc_subscr_name(conn->bsub));
*cause = GSM0808_CAUSE_INFORMATION_ELEMENT_OR_FIELD_MISSING;
return -1;

To view, visit change 31550. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Idfab0b7f6e97a6b67d140f967ddfe9b29818586e
Gerrit-Change-Number: 31550
Gerrit-PatchSet: 5
Gerrit-Owner: osmith <osmith@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: osmith <osmith@sysmocom.de>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-MessageType: merged