dexter submitted this change.

View Change


Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified
pcu_sock: don not continue when running out of TRX space

The info indication on pcu_sock cann only support a limited but
sufficient number of TRXs, when we detect that we overflow the maxiumum
number of TRXs, then break and do not continue.

(this is more or less a cosmetic problem)

Change-Id: If4d7eecaded22f86750283f7aa13072064724537
---
M src/common/pcu_sock.c
1 file changed, 16 insertions(+), 1 deletion(-)

diff --git a/src/common/pcu_sock.c b/src/common/pcu_sock.c
index daa1a57..4bd82e9 100644
--- a/src/common/pcu_sock.c
+++ b/src/common/pcu_sock.c
@@ -351,7 +351,7 @@
LOGPTRX(trx, DPCU, LOGL_NOTICE, "PCU interface (version %u) "
"cannot handle more than %zu transceivers => skipped\n",
PCU_IF_VERSION, ARRAY_SIZE(info_ind->trx));
- continue;
+ break;
}

info_ind_fill_trx(&info_ind->trx[trx->nr], trx);

To view, visit change 30878. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: If4d7eecaded22f86750283f7aa13072064724537
Gerrit-Change-Number: 30878
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier@sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-CC: pespin <pespin@sysmocom.de>
Gerrit-MessageType: merged