Attention is currently required from: neels.
Patch set 11:Code-Review +1
5 comments:
Patchset:
I think this patch looks ok. I would recommend to look at decimal_hex_to_str() a bit more closely to make sure it actually does the right thing.
File pySim/esim/saip/personalization.py:
Patch Set #11, Line 209: def get_values_from_pes(cls, pes: ProfileElementSequence) -> Generator:
As far as I understand ''' just marks a multiline comment, but shouldn't this be a doctstring?
Patch Set #11, Line 290: def decimal_hex_to_str(cls, val):
also have not seen single quotes as comment chars before...
Patch Set #11, Line 292: if isinstance(val, bytes):
Is it always ensured that we won't get sometimes bytes and sometimes bytearrays?
Patch Set #11, Line 297: val = unrpad(val, c)
You are sure that you want to turn val to ascii, like "4141" => "AA"? (am a bit confused since the method name suggests more that the input should be a hexstring or a bytearray with decimal digits and the output should be a string with the same digits.)
To view, visit change 40198. To unsubscribe, or for help writing mail filters, visit settings.