Attention is currently required from: bucketking657, laforge.
Patch set 2:Code-Review +1
View Change
1 comment:
File src/gsm/gsm48_ie.c:
Patch Set #2, Line 166: bcd_lv[0] = len;
Please add an extra check here:
/* Lengths spanning multiple bytes cannot be encoded */
if (len > 0xff)
return -EIO;
To view, visit change 44142. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I99521d30896f3d58ecfb28de290bce7e31388fca
Gerrit-Change-Number: 44142
Gerrit-PatchSet: 2
Gerrit-Owner: bucketking657 <joshuashilts@gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-Attention: laforge <laforge@osmocom.org>
Gerrit-Attention: bucketking657 <joshuashilts@gmail.com>
Gerrit-Comment-Date: Fri, 20 Nov 2026 16:48:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes