Attention is currently required from: fixeria.
4 comments:
Patchset:
Fine about the osmo-pcap wire framing. I wonder: Is the snaplen also used in the IP over IP setup which iirc can also be used instead of the osmo-pcap wire framing?
If that's the case, then there's no limit of uint16_t afaiu?
File include/osmo-pcap/common.h:
Patch Set #1, Line 70: #define OSMO_PCAP_MAX_SNAPLEN 65535
can we then set it to UINT16_MAX here?
File src/osmo_client_vty.c:
Patch Set #1, Line 202: "Bytes (effectively limited to 64 KiB by the osmo-pcap wire framing)\n")
Can you add the exact integer number here instead of 64KiB so user actually knows what to set it to?
File src/osmo_server_vty.c:
Patch Set #1, Line 377: "Bytes (effectively limited to 64 KiB by the osmo-pcap wire framing)\n")
Can you add the exact integer number here instead of 64KiB so user actually knows what to set it to?
To view, visit change 42836. To unsubscribe, or for help writing mail filters, visit settings.