Attention is currently required from: fixeria, laforge, neels.
1 comment:
Patchset:
pespin says use intermediate storage with mutexes in a comment at https://gerrit.osmocom.org/c/osmo-hnbgw/+/36385
For this one, my aim was to say that osmo-trx is doing it that way, not that you should do it that way.
nhofmeyr says directly write to rate_ctr, but still have a mutex around stats reporting, so that counter pairs are always in sync.
If you plan on keep the mutex locked while you gather counters from nft, that's a no go for me, you are locking access to rate_ctr/stat for a long period of time, most probably blocking the main thread also for the same amount of time.
If you plan to gather counters locally, then lock() then update/copy them to rate_ctr/stats then unlock(), this can be more acceptable and it's basically the option mentioned first quoted in this comment. Still, I think it's better going for osmo_itq to avoid problems accessing rate_ctr infrastructure (llist, etc.) which means you'd need to lock() unlock() everytime you want to update a metric, which is overkill.
To view, visit change 36538. To unsubscribe, or for help writing mail filters, visit settings.