Attention is currently required from: laforge, pespin.
View Change
1 comment:
File src/stream_cli.c:
Patch Set #5, Line 447: /* Forward message to read callback, also if the connection failed. */
I already though on the previous patch: Shouldn't this callback happen *before* reconnecting? Or it' […]
Yes, it is called at the end to prevent a use-after-free bug. The user may decide to destroy the cli instance.
To view, visit change 36020. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: Ie2335987c38863bad5de1d2d4dbdf4c8373f927f
Gerrit-Change-Number: 36020
Gerrit-PatchSet: 6
Gerrit-Owner: jolly <andreas@eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-Attention: laforge <laforge@osmocom.org>
Gerrit-Attention: pespin <pespin@sysmocom.de>
Gerrit-Comment-Date: Mon, 04 Mar 2024 10:45:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin@sysmocom.de>
Gerrit-MessageType: comment