Attention is currently required from: falconia.

View Change

3 comments:

• File src/common/l1sap.c:

  • Patch Set #2, Line 1250: /* A zero-length payload is never valid, it is merely a BFI marker

    Can you explain a bit more this change in logic here? It's not explained in the commit description so it's not clear why you added this.

  • Patch Set #2, Line 1253: if (!resp_msg->len)

    == 0 would be clearer here, since len is an int and not a bool.

• File src/common/vty.c:

  • Patch Set #2, Line 425: vty_out(vty, " rtp always-output%s", VTY_NEWLINE);

    what about "rtp tx-lost" or "rtp tx-forged-lost" or similar? "always-output" is a bit difficult to understand its meaning.

To view, visit change 32098. To unsubscribe, or for help writing mail filters, visit settings.