Attention is currently required from: Hoernchen.

Patch set 1:Code-Review -1

View Change

1 comment:

• File src/core/Makefile.am:

  • Patch Set #1, Line 62: context

    how many firmware users do we have? do we have firmware that wants random talloc allocation in bitve […]

    the point is not whether or not that change may make sense. The point is that you are sneaking it into a patch without documenting it clearly in the changelog. And as a secondary point, that it is a logically distinct change that would preced the current change.

    That's basically exactly what I was trying to convey with my previous review comment. Maybe this time I can manage to express myself more clearly.

To view, visit change 42308. To unsubscribe, or for help writing mail filters, visit settings.