Attention is currently required from: lynxis lazus, neels.

View Change

7 comments:

• File src/libmsc/msc_vty.c:

  • Patch Set #2, Line 536: gsmnet->vlr->cfg.ciph_sec_ctx_max_reuse = atoi(argv[0]);

    This double assignment with on top super long lines and indentation looks confusing.

• File src/libvlr/vlr_access_req_fsm.c:

  • Patch Set #2, Line 466: par->key_seq = par->vsub->last_tuple->key_seq;

    lots of indirection here, may make sense to add some intermediate ASSERT?

• File src/libvlr/vlr_auth_fsm.h:

  • Patch Set #2, Line 43: bool auth_ciph_sec_ctx_is_usable(struct vlr_subscr *vsub, uint8_t key_seq);

    const

• File src/libvlr/vlr_auth_fsm.c:

  • Patch Set #2, Line 697: bool auth_ciph_sec_ctx_is_usable(struct vlr_subscr *vsub, uint8_t key_seq)

    const vsub.

    Also order of functions in header is reversed as in here afaict?

  • Patch Set #2, Line 702: if (!at || key_seq == 0x7)

    so "at && key_seq == 0x7" is actually fine then? Or do you better need to split these cases?

• File tests/msc_vlr/msc_vlr_test_authen_reuse.c:

  • Patch Set #2, Line 40: net->vlr->cfg.auth_tuple_max_reuse_count = net->vlr->cfg.ciph_sec_ctx_max_reuse = set_max_reuse_count;

    let's please have these in separate lines!

• File tests/msc_vlr/msc_vlr_tests.c:

  • Patch Set #2, Line 681: net->vlr->cfg.auth_tuple_max_reuse_count = net->vlr->cfg.ciph_sec_ctx_max_reuse = 0;

    separate lines!

To view, visit change 43480. To unsubscribe, or for help writing mail filters, visit settings.