Attention is currently required from: neels.

Patch set 3:Code-Review +1

View Change

2 comments:

• File src/osmo-hnbgw/hnbgw.c:

  • Patch Set #3, Line 373: result = talloc_asprintf(OTC_SELECT, "%s %s", result, ctx->identity_info);

    Again, I hope this is not called every time we log a line.

• File src/osmo-hnbgw/hnbgw_cn.c:

  • Patch Set #3, Line 515: LOG_CNLINK(cnlink, DCN, LOGL_NOTICE, "using: cs7-%u %s <-> %s %s %s\n",

    This would rpboably better with a couple defines _FMT and _ARGS, so that it ends up in same log line and not in an extra one.

To view, visit change 33171. To unsubscribe, or for help writing mail filters, visit settings.