Attention is currently required from: jolly.

Patch set 3:Code-Review -1

View Change

4 comments:

• Patchset:

  • Patch Set #3:

    I'm not sure I'm understanding this commit. You are adding arrays but only using the first one despite configuring the global variable to something != 1?
    This shouldn't be submitted like this alone imho.

• File src/core/osmo_io.c:

  • Patch Set #3, Line 165: hdr->msg_max = (g_io_backend == OSMO_IO_BACKEND_IO_URING) ? g_io_uring_iov : 1;

    this info should be obtained from osmo_io_fd struct.

  • Patch Set #3, Line 406: struct msgb *msg = msghdr->msg[0];

    why is this and below always [0]?

• File src/core/osmo_io_internal.h:

  • Patch Set #3, Line 140: int msg_max;

    this field should probably be in struct osmo_iofd.

To view, visit change 40491. To unsubscribe, or for help writing mail filters, visit settings.