Attention is currently required from: fixeria, lynxis lazus.
Patch set 1:Code-Review -1
2 comments:
File include/osmocom/sgsn/mmctx.h:
Patch Set #1, Line 236: ue->conn_id
idea for a separate patch: `(ue)->conn_id`
Yes please @lynxis@fe80.eu edit this patch and add the parenthesis.
I would not print curly braces in the case of `NULL` at all.
We tend to do this null case as a "(ue) ? foo : bar".
This has the advantage that the whole logic is only executed in case there's a logging happening due to level+category being logged, thanks to macro expansion.
With your approach you are always running through at least an if+else. Please rework it.
To view, visit change 40698. To unsubscribe, or for help writing mail filters, visit settings.