Attention is currently required from: fixeria, laforge, osmith.
View Change
1 comment:
Commit Message:
Patch Set #1, Line 9:
it makes it impossible to reference the
component name under TESTPORT_PARAMETERS
I find the discussion a bit bizarre. Yes, spaces in file names require proper quoting. […]
So does that mean you also insist I should drop this patch and redo my other patches to use quotes instead? Or just reword the commit to drop the "impossible" keyword?
I still believe this patch is an improvement, but if several people oppose to it I will just drop it and redo other commits to get everything merged.
To view, visit change 36641. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iecefe7d98a5842872f1efc55e013f672186ef1a8
Gerrit-Change-Number: 36641
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: osmith <osmith@sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Attention: osmith <osmith@sysmocom.de>
Gerrit-Attention: laforge <laforge@osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Comment-Date: Tue, 30 Apr 2024 21:08:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith@sysmocom.de>
Comment-In-Reply-To: laforge <laforge@osmocom.org>
Comment-In-Reply-To: pespin <pespin@sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de>
Gerrit-MessageType: comment