Attention is currently required from: laforge, pespin.

View Change

1 comment:

• File src/osmo-hnbgw/ranap_rab_ass.c:

  • Patch Set #11, Line 34: int ranap_rab_ass_req_decode(RANAP_RAB_AssignmentRequestIEs_t *rab_assignment_request_ies, const uint8_t *data,

    My main concern here was to lower the risk to introduce memory leaks. […]

    given that there are

    RANAP_RAB_AssignmentRequestIEs_t raB_AssignmentRequestIEs;
    RANAP_RAB_AssignmentResponseIEs_t raB_AssignmentResponseIEs;

    in ranap_message, it probably makes sense to use those instead of RANAP_RANAP_PDU_t as input/output for the helper functions.

    What I haven't seen so far is an encoder that does the same as ranap_common_cn.c in reverse.

To view, visit change 26792. To unsubscribe, or for help writing mail filters, visit settings.