Attention is currently required from: bucketking657.
View Change
1 comment:
File src/gsm/gsm48_ie.c:
Patch Set #1, Line 140: * \param[in] max_len Maximum value of the L octet; \a bcd_lv must have
I agree. […]
Please rework the other patch as mentioned (feel free to improve my commnets as needed) and submit a new version of this patch here also as mentioned. Thanks!
To view, visit change 44142. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I99521d30896f3d58ecfb28de290bce7e31388fca
Gerrit-Change-Number: 44142
Gerrit-PatchSet: 1
Gerrit-Owner: bucketking657 <joshuashilts@gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-Attention: bucketking657 <joshuashilts@gmail.com>
Gerrit-Comment-Date: Thu, 19 Nov 2026 17:34:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin@sysmocom.de>
Comment-In-Reply-To: bucketking657 <joshuashilts@gmail.com>