Attention is currently required from: daniel, pespin.

View Change

8 comments:

• File include/osmocom/sgsn/gprs_routing_area.h:

  • Patch Set #9, Line 19: ras

    ra_list

    Acknowledged

  • Patch Set #9, Line 19: ras

    ra_list

    Done

  • Patch Set #9, Line 32: /* contains cells which are in BVC_UNBLOCKED */

    Not sure what you mean here. […]

    Acknowledged

  • Patch Set #9, Line 32: /* contains cells which are in BVC_UNBLOCKED */

    Not sure what you mean here. […]

    Done

• File src/sgsn/gprs_routing_area.c:

  • Patch Set #5, Line 45: if (!drop_empty_ra) {

    I'll remove empty RoutingAreas for now

    Done

  • Patch Set #5, Line 281: }

    All this function is also a bit cumbersome, I encourage doing a second thought too.

    Done

• File src/sgsn/gprs_routing_area.c:

  • Patch Set #9, Line 235: /* FIXME: drop old BVCI? How to handle the same RAI/CellId via different BVCIs? */

    Yeah, I would drop the old one. […]

    I'm keeping for now the old one and replacing it's parameters, because removing doesn't do anything at the moment.

  • Patch Set #9, Line 237: LOGP(DRA, LOGL_INFO, "GERAN Cell changed DLCI. Old: nsei/bvci 0x%04x/0x%04x New: nsei/bvci 0x%04x/0x%04x\n",

    gbproxy uses %05u, ns2 uses %d, sometimes %u and other times %05u […]

    Done

To view, visit change 37864. To unsubscribe, or for help writing mail filters, visit settings.