Attention is currently required from: dexter.

4 comments:

File pySim/javacard.py:
- Patch Set #2, Line 47: __component
  AFAICT, you are basically declaring a _class_ variable here. It will be identical across all the instances of the class. However, it seems more like you're storing per-instance state in it?
- Patch Set #2, Line 99:
  I think a generic implementation of a CAP file support shouldn't return the loadfile as hex-string but as bytes. The fact that whatever downstream apdu user we have may need hexstr should not have implications on a generic CAP file parser. Also, the function signature is missing the declaration of the return type ("-> Hexstr" in the current one, "-> bytes" in my proposal).
- Patch Set #2, Line 118: def get_loadfile_aid(self):
  missing declaration of return type (-> Hexstr)
- Patch Set #2, Line 127: def get_applet_aid(self, index:int = 0):
  missing declaration of return type (-> Hexstr)

To view, visit change 39198. To unsubscribe, or for help writing mail filters, visit settings.