Attention is currently required from: fixeria, pespin.

View Change

3 comments:

• File msc/BSC_ConnectionHandler.ttcn:

  • Patch Set #2, Line 986: /* What to Codec (Chosen) to send back in Assignment Complete */

    "What to Codec to" doesn't make sense to me? […]

    thx

  • Patch Set #2, Line 993: BSSMAP_FIELD_CodecElements re_ass_req_codecs,

    Sounds like "optional" is missing in this field.

    it is always {FR} by default, so it is never actually absent.
    Should it still be marked optional?

    There is no practical benefit of 'optional', because there already is the expect_re_assignment flag -- that bool indicates usage for both re_ass_req_codecs and re_ass_compl_chosen_codec, so adding more optionality makes checks for presence more complex; point being that there is no caller ever using the optional part.

    The same is true for the already existing transaction_id: it is marked optional, yet it is always initialized. So maybe I am wrong here?
    But why add more possible states == more complexity??

  • Patch Set #2, Line 995: re_ass_compl_chosen_codec

    Sounds like "optional" is missing in this field.

    (s.a.)

To view, visit change 35053. To unsubscribe, or for help writing mail filters, visit settings.