Attention is currently required from: neels, fixeria.

8 comments:

Commit Message:
- Patch Set #8, Line 9: Limit length of optional Data parameter is 130 bytes according to ITU-T Rec Q.713 §4.2..§4.5. If we receive CR, CC or
  This reads a bit weird. […]
  Done
File src/sccp_scoc.c:
- Patch Set #8, Line 50: #include <osmocom/core/msgb.h>
  cosmetic: move it below to other imports from 'osmocom/core'.
  Done
- Patch Set #8, Line 603: xua_class_msg_name
  xua_class_msg_name() operates on a static buffer, so calling it more than once in a logging statemen […]
  Done
- Patch Set #8, Line 613: lim
  IIUC, this value is always SCCP_MAX_DATA. […]
  No, it's not.
- Patch Set #8, Line 623: xua_opt_data_cache_check
  When I see function names ending with _check, I expect them to do nothing else but check something a […]
  Renamed and updated docs for clarity.
- Patch Set #8, Line 650: static bool xua_opt_data_length_check(struct sccp_connection *conn, const struct osmo_scu_prim *prim, int msg_type)
  Again, this naming is really confusing. […]
  Done
- Patch Set #8, Line 659: break
  unreachable
  Yes?
- Patch Set #8, Line 1006: xua_opt_data_clear_cache
  IMO, this should be done in conn_destroy().
  Done

To view, visit change 29084. To unsubscribe, or for help writing mail filters, visit settings.