Attention is currently required from: osmith, neels, fixeria, msuraev.

View Change

1 comment:

• File src/core/logging_gsmtap.c:

  • Patch Set #12, Line 186: target->tgt_gsmtap.src_addr = talloc_strdup(target, src);

    See - https://gerrit.osmocom. […]

    But afaiu the test you are extending there doesn't seem to be using gsmtap at all?
    $ grep -rIc gsmtap libosmocore/tests/logging
    libosmocore/tests/logging/logging_test.ok:0
    libosmocore/tests/logging/logging_test.c:0
    libosmocore/tests/logging/logging_test.err:0
    libosmocore/tests/logging/logging_vty_test.c:0
    libosmocore/tests/logging/logging_vty_test.vty:0

    In any case, I was basically asking if you can look that you checked and made sure the pointer was not allocated already in any of the functions called before it being assigned here.

To view, visit change 31513. To unsubscribe, or for help writing mail filters, visit settings.