Attention is currently required from: Hoernchen, laforge, pespin.

Patch set 4:Code-Review -1

View Change

2 comments:

• File src/osmo-bts-trx/trx_if.h:

  • Patch Set #3, Line 11: OSMO_MAX(2 * (GSM_BURST_LEN + 2), (EGPRS_BURST_LEN + 2))

    `EGPRS_BURST_LEN` is known to be 3 times greater than `GSM_BURST_LEN` (because 8-PSK fits 3 bits per symbol), so `OSMO_MAX` would always evaluate to `EGPRS_BURST_LEN + 2`.

  • Patch Set #3, Line 12: TRXD_BURST_SIZE_MAX * TRX_NR_TS

    Here you're accounting for up to 8 8-PSK bursts, you're taking into account those 2 dummy bytes (from TRXDv0), but you're missing the TRXD header size here. This value depends on the protocol version, but AFAIR TRXDv2 header is the largest one being `8 + 4` (4 for TDMA Fn in the first PDU) bytes.

To view, visit change 41660. To unsubscribe, or for help writing mail filters, visit settings.