Attention is currently required from: jolly, pespin.
View Change
1 comment:
File src/core/osmo_io.c:
Patch Set #1, Line 339: talloc_set_name(msg, "osmo_io_rx_msgb");
It happens at time the msgb is allocated, where as name we use a pointer to the (dynamically allocat […]
I think it would be better to not even set the msgb name to the name of the iofd in the first place, avoiding having to change it later on here.
To view, visit change 36121. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ib8dae924fa2d94a7f636136ba7279b965a18cf5b
Gerrit-Change-Number: 36121
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas@eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-CC: pespin <pespin@sysmocom.de>
Gerrit-Attention: jolly <andreas@eversberg.eu>
Gerrit-Attention: pespin <pespin@sysmocom.de>
Gerrit-Comment-Date: Thu, 29 Feb 2024 14:27:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge@osmocom.org>
Comment-In-Reply-To: pespin <pespin@sysmocom.de>
Gerrit-MessageType: comment