Attention is currently required from: dexter.

View Change

4 comments:

• File contrib/csv-to-pgsql.py:

  • Patch Set #1, Line 15: __name__

    See my comment in `pySim-shell.py`.

  • Patch Set #1, Line 38: log = PySimLogger.get(__name__)

    This becomes an equivalent of the logger above, and thus can be removed?

• File pySim-shell.py:

  • Patch Set #1, Line 77: __name__

    Since this is the top level of the hierarchy, it's actually desirable to set the module name manually (e.g. `"pySim-shell"`) here. Otherwise it will show up as `__main__` in logging.

    Same applies to `pySim-trace.py` and others, but AFAICS they're not using logging yet.

• File pySim/card_key_provider.py:

  • Patch Set #1, Line 41: PySimLogger.get

    You no longer need to call `PySimLogger.get` here nor in other modules of the `pySim` namespace. Instead, you can do the following:

    ```
    import logging # already imported above

    log = logging.getLogger(__name__)
    ```

    Being part of the module hierarchy, this module inherits logging configuration of the parent loggers. The only place where you'll still need to use the `PySimLogger` API is top-level scripts (entry-points) like `pySim-shell.py`.

    This can be done in a separate patch.

To view, visit change 41890. To unsubscribe, or for help writing mail filters, visit settings.